-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception in ResourceBuilderExtensions when running in AWS Lambda #1932
Conversation
This works even when the assembly was not loaded directly from a file.
Codecov Report
@@ Coverage Diff @@
## main #1932 +/- ##
==========================================
- Coverage 84.61% 84.39% -0.22%
==========================================
Files 245 188 -57
Lines 6974 6108 -866
==========================================
- Hits 5901 5155 -746
+ Misses 1073 953 -120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. Blocking PR until the changelog is moved to right place to avoid confusion
Fixes #1908.
Changes
Loaded assembly file version from
AssemblyFileVersionAttribute
rather than usingFileVersionInfo.GetVersionInfo
as this works with assemblies which weren't loaded directly from a file on disk. Added defensive catch block.CHANGELOG.md
updated for non-trivial changes