Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in ResourceBuilderExtensions when running in AWS Lambda #1932

Merged
merged 6 commits into from
Mar 24, 2021

Conversation

mbergin
Copy link
Contributor

@mbergin mbergin commented Mar 23, 2021

Fixes #1908.

Changes

Loaded assembly file version from AssemblyFileVersionAttribute rather than using FileVersionInfo.GetVersionInfo as this works with assemblies which weren't loaded directly from a file on disk. Added defensive catch block.

  • CHANGELOG.md updated for non-trivial changes

@mbergin mbergin requested a review from a team March 23, 2021 15:42
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 23, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1932 (c4fad04) into main (1c99210) will decrease coverage by 0.21%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
- Coverage   84.61%   84.39%   -0.22%     
==========================================
  Files         245      188      -57     
  Lines        6974     6108     -866     
==========================================
- Hits         5901     5155     -746     
+ Misses       1073      953     -120     
Impacted Files Coverage Δ
...enTelemetry/Resources/ResourceBuilderExtensions.cs 88.46% <60.00%> (-7.20%) ⬇️
src/OpenTelemetry/Sdk.cs 100.00% <0.00%> (ø)
src/OpenTelemetry.Api/Metrics/ProxyMeter.cs
src/OpenTelemetry/Metrics/Int64MeasureMetricSdk.cs
...metry.Api/Metrics/NoopInt64ObserverMetricHandle.cs
src/OpenTelemetry/Metrics/MeterProviderBuilder.cs
src/OpenTelemetry.Api/Metrics/MeasureMetric.cs
...ometheus/Implementation/PrometheusMetricBuilder.cs
src/OpenTelemetry/Metrics/Export/DoubleSumData.cs
...gregators/DoubleMeasureMinMaxSumCountAggregator.cs
... and 49 more

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Blocking PR until the changelog is moved to right place to avoid confusion

@cijothomas cijothomas merged commit 5f1acbf into open-telemetry:main Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services running on AWS Lambda fail to start due to exception thrown in constructing OpenTelemetry classes
4 participants