AspNet.TelemetryHttpModule public api + test fixes + renames #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
changed the title
reyang
reviewed
Aug 9, 2021
| @@ -30,8 +30,7 @@ Telemetry correlation http module enables cross tier telemetry tracking. | |||
|
|
|||
| public void OnNext(DiagnosticListener listener) | |||
| { | |||
| if (listener.Name == "Microsoft.AspNet.TelemetryCorrelation" || | |||
| listener.Name == "System.Net.Http" ) | |||
There was a problem hiding this comment.
I don't think so. My guess is the example snippet came from some code listening to this module and something else instrumenting outgoing requests?
reyang
approved these changes
Aug 9, 2021
10 tasks
|
@reyang @cijothomas @alanwest Everyone OK renaming the diagnostic source from "Microsoft.AspNet.TelemetryCorrelation" -> "OpenTelemetry.Instrumentation.AspNet.Telemetry"? At the moment, it is backwards compatible and could use the same name. But I'm thinking we'll add more features to it so it might be nice to break with the past and not be tied to the existing contract(s). |
alanwest
approved these changes
Aug 9, 2021
cijothomas
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2222.
Changes