Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw on invalid histogram bounds #2573

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Throw on invalid histogram bounds #2573

merged 3 commits into from
Nov 9, 2021

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Nov 8, 2021

Fixes #2566

Changes

Throws ArgumentException when invalid histogram bounds are provided.
The bounds must be in ascending order and contain distinct values.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #2573 (beae2df) into main (8029751) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
+ Coverage   80.84%   80.87%   +0.02%     
==========================================
  Files         254      254              
  Lines        8552     8559       +7     
==========================================
+ Hits         6914     6922       +8     
+ Misses       1638     1637       -1     
Impacted Files Coverage Δ
...rc/OpenTelemetry/Metrics/HistogramConfiguration.cs 42.85% <ø> (ø)
...elemetry/Metrics/MeterProviderBuilderExtensions.cs 81.81% <100.00%> (+4.89%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️

@mic-max mic-max marked this pull request as ready for review November 8, 2021 23:53
@mic-max mic-max requested a review from a team November 8, 2021 23:53
@cijothomas cijothomas merged commit 05990ae into open-telemetry:main Nov 9, 2021
@mic-max mic-max deleted the hist-bounds-throw branch November 9, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram bounds must be validated
3 participants