Separate auto-collectors and make them accept Tracer #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
|
@pakrym can you please have a look? nothing breaking here, just changing infra around AzureSdk collector a bit. |
austinlparker
approved these changes
Oct 9, 2019
|
The |
this is a new OTel requirement |
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
…ons (open-telemetry#266) * Rename Contrib Preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have generic Requests and Dependency collectors that may bring more features inside.
E.g. Dependency collector enables HTTPClient and Azure SDK at the same time - there is no way to turn them on/off separately.
So basically it complicates configuration and code around the subscription.
The change is a step on the way to clean configuration story (#261) and separate configuration for collectors.