-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing configuration API #267
Conversation
Looks good! Lots of public method parameters should have null checks but that's picking nits 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the null checks, I think it might be useful to have an explicit setter for the tracer name, as it's not entirely clear how that gets set right now or what you should use? Overall I think it's an improvement though.
o.ServiceName = "my-service"; | ||
o.Endpoint = new Uri("https://<zipkin-server:9411>/api/v2/spans")))) | ||
{ | ||
var tracer = tracerFactory.GetTracer("zipkin-test"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the tracer name coming from here?
using (var tracerFactory = TracerFactory.Create( | ||
builder => builder.SetExporter(new StackdriverTraceExporter("YOUR-GOOGLE-PROJECT-ID")))) | ||
{ | ||
var tracer = tracerFactory.GetTracer("stackdriver-test"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, where is tracer named in example?
using (var tracerFactory = TracerFactory.Create(builder => builder | ||
.UseApplicationInsights(config => config.InstrumentationKey = "instrumentation-key"))) | ||
{ | ||
var tracer = tracerFactory.GetTracer("application-insights-test"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracer name?
@austinlparker can you elaborate?
So, could you help me understand if you want to improve the documentation or mean some API change? |
Co-Authored-By: Austin Parker <austin@lightstep.com>
fd3e27a
to
8178537
Compare
This has started in #261.
Fixes #206, #93
Before
After