Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test namespace adjustment #2903

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

cijothomas
Copy link
Member

Less cluttered Test Explorer :)

image
Could use some more refactors to make it cleaner. Like moving Instrumentation.Tests elsewhere?

@cijothomas cijothomas requested a review from a team February 16, 2022 02:19
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #2903 (84d5e7b) into main (d7afc1b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
- Coverage   84.20%   84.17%   -0.03%     
==========================================
  Files         252      252              
  Lines        8893     8893              
==========================================
- Hits         7488     7486       -2     
- Misses       1405     1407       +2     
Impacted Files Coverage Δ
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) ⬇️

@reyang
Copy link
Member

reyang commented Feb 16, 2022

Less cluttered Test Explorer :)

image Could use some more refactors to make it cleaner. Like moving Instrumentation.Tests elsewhere?

If you don't use Visual Studio, the problem would disappear 😄

@cijothomas cijothomas merged commit 360957d into open-telemetry:main Feb 16, 2022
@cijothomas cijothomas deleted the cijothomas/min12 branch February 16, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants