Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Activity Filter capability for OpenTelemetry.Instrumentation.SqlClient #3342

Closed
wants to merge 6 commits into from
Closed

Feature: Activity Filter capability for OpenTelemetry.Instrumentation.SqlClient #3342

wants to merge 6 commits into from

Conversation

jvinters
Copy link

@jvinters jvinters commented Jun 5, 2022 •
edited
Loading

Fixes #.

Changes

Related: #2020, open-telemetry/opentelemetry-dotnet-contrib#1757

  1. Added a Filter option to the SqlClientIntrumentation library in order to provide the capability of filtering out activities.
  2. Updated Unit tests

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@jvinters jvinters requested a review from a team June 5, 2022 23:24
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 5, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@jvinters jvinters changed the title SqlclientIntrumentation Activity Filter Feature: Activity Filter capability for OpenTelemetry.Instrumentation.SqlClient Jun 5, 2022
cijothomas
cijothomas reviewed Jun 9, 2022
View reviewed changes
src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs
{
if (this.options.EventFilter(activity, "OnCustom", command) == false)
{
SqlClientInstrumentationEventSource.Log.FilterException(activity.OperationName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no exception here?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jun 17, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 24, 2022
@Driedas
Copy link
Contributor

Driedas commented Sep 20, 2022

@cijothomas would it be possible to reopen this PR? Happy to help with any outstanding issues. Your comment above re: possible exception was the only issue?

@cijothomas
Copy link
Member

@jvinters Hi do you have time to work on this? Or let @Driedas offer a new PR based on this ?

@Driedas
Copy link
Contributor

Driedas commented Oct 7, 2022

@cijothomas @jvinters are we deadlocked here?

@cijothomas
Copy link
Member

@Driedas You can open a new PR, and mention this PR in the description. Thanks.

@Driedas Driedas mentioned this pull request Oct 7, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

Assignees
No one assigned
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvinters @Driedas @cijothomas