Limit character set according to spec #3821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
\w
matches to more than just the intendeda-zA-Z0-9_
https://learn.microsoft.com/en-us/dotnet/standard/base-types/character-classes-in-regular-expressions#word-character-wBefore the change the addition to
InvalidInstrumentNames
would fail the test. the value isaµ
. The Micro is consideredLetter, Lowercase
by the\w
match. But this is just to show that any character belonging to the categories shown could have made an instrument name become out of spec.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes