[SDK] Remove the dependency on M.E.Options 5.0 #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
commented
Jan 20, 2023
| @@ -31,7 +31,7 @@ internal sealed class SdkLimitOptions | |||
| private int? spanLinkAttributeCountLimit; | |||
| private bool spanLinkAttributeCountLimitSet; | |||
|
|
|||
| internal SdkLimitOptions() | |||
| public SdkLimitOptions() | |||
There was a problem hiding this comment.
Note: The class is still internal this just satisfies the new() constraint which Options 3.1 requires of TOptions.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4093 +/- ##
==========================================
+ Coverage 85.46% 85.56% +0.10%
==========================================
Files 292 293 +1
Lines 11306 11330 +24
==========================================
+ Hits 9663 9695 +32
+ Misses 1643 1635 -8
|
reyang
reviewed
Jan 24, 2023
Comment on lines
+88
to
+89
| } | ||
| foreach (IPostConfigureOptions<TOptions> post in _postConfigures) |
There was a problem hiding this comment.
nit:
Suggested change
| } | |
| foreach (IPostConfigureOptions<TOptions> post in _postConfigures) | |
| } | |
| foreach (IPostConfigureOptions<TOptions> post in _postConfigures) |
alanwest
approved these changes
Jan 24, 2023
cijothomas
approved these changes
Jan 25, 2023
aunikitin
pushed a commit
to aunikitin/opentelemetry-dotnet
that referenced
this pull request
Feb 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4084
Changes
Removes the direct reference to Microsoft.Extensions.Options 5.0 from SDK and instead pulls in the newer OptionsFactory bits with some modifications for what SDK needs.
TODOs
CHANGELOG.mdupdated for non-trivial changes