Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry.sdk.* attributes to default resource #4369

Merged

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Apr 5, 2023

The telemetry.sdk.* resource attributes are now required by default. See: open-telemetry/opentelemetry-specification#3202

@alanwest alanwest requested a review from a team April 5, 2023 22:07
Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs changelog entry.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #4369 (65825a0) into main (0004895) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 65825a0 differs from pull request most recent head 0a3a9bb. Consider uploading reports for the commit 0a3a9bb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4369      +/-   ##
==========================================
+ Coverage   84.72%   84.76%   +0.03%     
==========================================
  Files         300      300              
  Lines       12003    12006       +3     
==========================================
+ Hits        10170    10177       +7     
+ Misses       1833     1829       -4     
Impacted Files Coverage Δ
src/OpenTelemetry/Resources/ResourceBuilder.cs 91.93% <100.00%> (+0.41%) ⬆️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants