Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Add note on ilogger scopes #4818

Merged
merged 14 commits into from
Aug 30, 2023
Merged

[otlp] Add note on ilogger scopes #4818

Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fe8a1db
Add notes about experimental attributes and scopes
vishweshbankwar Aug 30, 2023
372e300
add severity as experimental
vishweshbankwar Aug 30, 2023
dc9d371
fix md
vishweshbankwar Aug 30, 2023
1a20128
rmv link
vishweshbankwar Aug 30, 2023
632cf94
undo
vishweshbankwar Aug 30, 2023
9e0b4c0
pre-release note
vishweshbankwar Aug 30, 2023
e99b18f
pr feedback
vishweshbankwar Aug 30, 2023
5ca6695
docfx
vishweshbankwar Aug 30, 2023
e43ca02
Update src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md
vishweshbankwar Aug 30, 2023
e1d6115
fix typo
vishweshbankwar Aug 30, 2023
5633777
reword
vishweshbankwar Aug 30, 2023
518bf3e
remove experimental section
vishweshbankwar Aug 30, 2023
d9b5caf
Merge branch 'main' into vibankwa/add-note-about-ilogger-attributes
utpilla Aug 30, 2023
f51bc66
Update src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md
utpilla Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,15 @@ Core](../../examples/AspNetCore/Program.cs) example app. Check this
for configuring OpenTelemetry with `ILogger` for certain application types such
as ASP.NET Core and .NET Worker.

**ILogger Scopes**: OTLP Log Exporter supports exporting ILogger scopes as
utpilla marked this conversation as resolved.
Show resolved Hide resolved
Attributes. Scopes must be enabled at the SDK level using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Attributes. Scopes must be enabled at the SDK level using
attributes. Scopes must be enabled at the SDK level using

[IncludeScopes](../../docs/logs/customizing-the-sdk/Readme.md#includescopes)
setting on `OpenTelemetryLoggerOptions`.

> **Note**
> Scope attributes with key set as empty string or `{OriginalFormat}`
are ignored by exporter. Duplicate keys are exported as is.

CodeBlanch marked this conversation as resolved.
Show resolved Hide resolved
## Configuration

You can configure the `OtlpExporter` through `OtlpExporterOptions`
Expand Down