Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #4899

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Minor cleanup #4899

merged 4 commits into from
Sep 29, 2023

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 29, 2023

Clean up after #4885.

@reyang reyang requested a review from a team September 29, 2023 01:55
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #4899 (cdaaec1) into main (0b2d036) will increase coverage by 0.37%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4899      +/-   ##
==========================================
+ Coverage   82.88%   83.26%   +0.37%     
==========================================
  Files         294      294              
  Lines       12200    12200              
==========================================
+ Hits        10112    10158      +46     
+ Misses       2088     2042      -46     
Flag Coverage Δ
unittests 83.26% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit c03ee85 into open-telemetry:main Sep 29, 2023
49 checks passed
@reyang reyang deleted the reyang/cleanup branch September 29, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants