Fixed Missing Endpoint

[cliedeman]

When an exception if processed by the ExceptionHandler middleware the original endpoint is deleted

Fixes #5134

Changes

Source endpoint from exception handler feature

Merge requirement checklist

• CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[cliedeman]

I have finished the code changes but I am struggling with the tests.

The new test case currently passest on dotnet 7 but fails on 8 with the metrics route being empty.

[vishweshbankwar]

I have finished the code changes but I am struggling with the tests.

The new test case currently passest on dotnet 7 but fails on 8 with the metrics route being empty.

@cliedeman, Thank you for reporting the issue and proposing a solution. It looks good, but given its impact on metrics instrumentation, it would be good to get confirmation from @JamesNK before proceeding. Metrics instrumentation is done natively starting .NET 8.0 and it is following the same logic as we do currently. Anything we update here, we would like to keep the changes in sync so that the experience is consistent across different .NET versions.

[cliedeman]

Thanks @vishweshbankwar that explains the change in behaviour.

[JamesNK]

Thanks for the heads up. I've created an aspnetcore issue to look into this - dotnet/aspnetcore#52648

[github-actions]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

[cliedeman]

Blocked on #52648 being back ported

[alanwest]

Blocked on #52648 being back ported

Noted here dotnet/aspnetcore#52648 (comment), this fix will be available in 8.0.2. It only addresses things for metrics.

I'm reopening your PR as your fix to this instrumentation is still valuable because it addresses both traces and metrics as well as benefitting .NET 6 and 7 users.

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (6250307) 83.38% compared to head (e9a836b) 83.07%.
Report is 34 commits behind head on main.

❗ Current head e9a836b differs from pull request most recent head e340c76. Consider uploading reports for the commit e340c76 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5135      +/-   ##
==========================================
- Coverage   83.38%   83.07%   -0.32%     
==========================================
  Files         297      272      -25     
  Lines       12531    11985     -546     
==========================================
- Hits        10449     9956     -493     
+ Misses       2082     2029      -53     

Flag	Coverage Δ
unittests	?
unittests-Instrumentation-Experimental	25.07% <90.00%> (?)
unittests-Instrumentation-Stable	25.07% <90.00%> (?)
unittests-Solution-Experimental	83.04% <44.82%> (?)
unittests-Solution-Stable	82.99% <44.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...etryProtocol/Implementation/ExperimentalOptions.cs	100.00% <ø> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs	100.00% <100.00%> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs	93.45% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs	89.79% <100.00%> (+0.21%)	⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs	89.74% <100.00%> (+0.26%)	⬆️
...plementation/HttpWebRequestActivitySource.netfx.cs	80.77% <100.00%> (ø)
...emetry/Metrics/Exemplar/SimpleExemplarReservoir.cs	80.43% <100.00%> (ø)
...mentation/Retry/OtlpExporterTransmissionHandler.cs	0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes

[cliedeman]

Thanks @alanwest will address the feedback soon

[cliedeman]

@alanwest I have address the feedback. How do you suggest we make the tests pass for 8 until the fix is released?

[github-actions]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[vishweshbankwar]

@cliedeman Could you address the comments from @alanwest? We will move forward with the merge then. Thanks!

[cliedeman]

@vishweshbankwar feedback addresed

[alanwest]

Thanks, @cliedeman!