Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Minor refactor #5164

Merged

Conversation

vishweshbankwar
Copy link
Member

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar requested a review from a team December 13, 2023 17:50
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #5164 (4df24d4) into main (a736574) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5164      +/-   ##
==========================================
- Coverage   83.46%   83.45%   -0.02%     
==========================================
  Files         297      297              
  Lines       12368    12366       -2     
==========================================
- Hits        10323    10320       -3     
- Misses       2045     2046       +1     
Flag Coverage Δ
unittests 83.45% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ementation/HttpHandlerMetricsDiagnosticListener.cs 88.23% <100.00%> (-0.23%) ⬇️
...plementation/HttpWebRequestActivitySource.netfx.cs 80.77% <100.00%> (-0.04%) ⬇️

... and 7 files with indirect coverage changes

@utpilla utpilla merged commit ecaa601 into open-telemetry:main Dec 13, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants