Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Expose Exemplars stable #5607

Merged
merged 7 commits into from
May 13, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented May 10, 2024

Relates to #2527

Changes

  • Exposes the Exemplar APIs previously covered by OTEL1002 as part of the stable API

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels May 10, 2024
@CodeBlanch CodeBlanch requested a review from a team May 10, 2024 20:16
@CodeBlanch CodeBlanch mentioned this pull request May 10, 2024
6 tasks
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (6250307) to head (385278e).
Report is 220 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5607      +/-   ##
==========================================
+ Coverage   83.38%   85.79%   +2.40%     
==========================================
  Files         297      254      -43     
  Lines       12531    10982    -1549     
==========================================
- Hits        10449     9422    -1027     
+ Misses       2082     1560     -522     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.77% <ø> (?)
unittests-Solution-Stable 85.70% <ø> (?)
unittests-Unstable-Core 19.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Metrics/Builder/MeterProviderBuilderExtensions.cs 98.42% <ø> (-1.58%) ⬇️
src/OpenTelemetry/Metrics/Exemplar/Exemplar.cs 87.09% <ø> (-12.91%) ⬇️
...try/Metrics/Exemplar/ReadOnlyExemplarCollection.cs 78.57% <ø> (ø)
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 95.08% <ø> (+7.24%) ⬆️
src/OpenTelemetry/Metrics/MetricPoint.cs 94.24% <ø> (+25.76%) ⬆️
src/OpenTelemetry/ReadOnlyFilteredTagCollection.cs 100.00% <ø> (ø)

... and 108 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit af3c389 into open-telemetry:main May 13, 2024
43 checks passed
@CodeBlanch CodeBlanch deleted the sdk-exemplars-stable branch May 13, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants