Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove options from end and make SpanContext specific class #57

Merged
merged 1 commit into from
Jun 3, 2019
Merged

remove options from end and make SpanContext specific class #57

merged 1 commit into from
Jun 3, 2019

Conversation

SergeyKanzhelev
Copy link
Member

  1. ISpan.End -> remove options argument
  2. Make SpanContext final and specific

@SergeyKanzhelev SergeyKanzhelev merged commit bca11b8 into open-telemetry:master Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev deleted the sergkanz/forgottenPieces branch June 3, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinlparker austinlparker austinlparker approved these changes

@discostu105 discostu105 Awaiting requested review from discostu105

@lmolkova lmolkova Awaiting requested review from lmolkova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeyKanzhelev @austinlparker