Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Nullable #5881

Merged

Conversation

ysolomchenko
Copy link
Contributor

Towards #3958

Changes

Examples mark as nullable

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ysolomchenko ysolomchenko requested a review from a team as a code owner October 3, 2024 07:59
@github-actions github-actions bot added the documentation Documentation related label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.26%. Comparing base (6250307) to head (4654711).
Report is 346 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5881      +/-   ##
==========================================
+ Coverage   83.38%   86.26%   +2.87%     
==========================================
  Files         297      257      -40     
  Lines       12531    11219    -1312     
==========================================
- Hits        10449     9678     -771     
+ Misses       2082     1541     -541     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.25% <ø> (?)
unittests-Project-Stable 86.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 238 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 36d5900 into open-telemetry:main Oct 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants