-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Export instrumentation scope attributes from ActivitySource.Tags #5897
[otlp] Export instrumentation scope attributes from ActivitySource.Tags #5897
Conversation
…itySource.Tags in OTLP exporter.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5897 +/- ##
==========================================
+ Coverage 83.38% 86.30% +2.91%
==========================================
Files 297 257 -40
Lines 12531 11252 -1279
==========================================
- Hits 10449 9711 -738
+ Misses 2082 1541 -541
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
…ajkumar-rangaraj/opentelemetry-dotnet into rajrang/otlpActivitySourceTags
…ajkumar-rangaraj/opentelemetry-dotnet into rajrang/otlpActivitySourceTags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: OTLP Exporter part from #5701
Design discussion issue
Changes
Please provide a brief description of the changes here.
Introduces support for exporting attributes from
ActivitySource.Tags
via the OTLP exporterMerge requirement checklist
CHANGELOG.md
files updated for non-trivial changes