Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] cleanup #nullable disable #5901

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 14, 2024

Towards #3958

Please merge after #5900

Changes

[repo] cleanup #nullable disable + update contributing guide

There is couple (3) of leftovers of #nullable disable. It is needed for auto-generated files.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added documentation Documentation related pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (6250307) to head (552411a).
Report is 349 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5901      +/-   ##
==========================================
+ Coverage   83.38%   86.30%   +2.92%     
==========================================
  Files         297      257      -40     
  Lines       12531    11219    -1312     
==========================================
- Hits        10449     9683     -766     
+ Misses       2082     1536     -546     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.26% <ø> (?)
unittests-Project-Stable 86.21% <ø> (?)
unittests-Solution 85.95% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 85.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...xporter.Console/Implementation/ConsoleTagWriter.cs 11.11% <ø> (ø)
....Exporter.Zipkin/Implementation/ZipkinTagWriter.cs 63.63% <ø> (ø)

... and 237 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review October 14, 2024 09:51
@Kielek Kielek requested a review from a team as a code owner October 14, 2024 09:51
Copy link
Contributor

@ysolomchenko ysolomchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 1a68b49 into open-telemetry:main Oct 14, 2024
47 of 49 checks passed
@Kielek Kielek deleted the nullable-cleanup branch October 14, 2024 17:14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kielek

Should we remove "nullable enabled" from here too?

* [ ] [CONTRIBUTING](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/CONTRIBUTING.md) guidelines followed (license requirements, nullable enabled, static analysis, etc.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave it there for new contributors who create projects and files with nullable disabled for some reason, and they can already see this line where they can read and understand that files must have nullable enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants