Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] OTLP Exporter Custom serializer Part 2 - Resources #5916

Merged

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes Part of #5730, Follow up #5910
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Added custom serialization for the OTLP Resource part.
  • Updated the tests to deserialize the bytes and validate them against the content generated from Google Protobuf.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner October 22, 2024 21:54
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 77.47748% with 25 lines in your changes missing coverage. Please review.

Project coverage is 86.30%. Comparing base (6250307) to head (18be666).
Report is 359 commits behind head on main.

Files with missing lines Patch % Lines
...ol/Implementation/Serializer/ProtobufSerializer.cs 22.72% 17 Missing ⚠️
...ation/Serializer/ProtobufOtlpResourceSerializer.cs 88.23% 4 Missing ⚠️
...Implementation/Serializer/ProtobufOtlpTagWriter.cs 92.72% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5916      +/-   ##
==========================================
+ Coverage   83.38%   86.30%   +2.91%     
==========================================
  Files         297      260      -37     
  Lines       12531    11456    -1075     
==========================================
- Hits        10449     9887     -562     
+ Misses       2082     1569     -513     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.17% <77.47%> (?)
unittests-Project-Stable 86.27% <77.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/Serializer/ProtobufOtlpResourceSerializer.cs 88.23% <88.23%> (ø)
...Implementation/Serializer/ProtobufOtlpTagWriter.cs 92.72% <92.72%> (ø)
...ol/Implementation/Serializer/ProtobufSerializer.cs 85.21% <22.72%> (ø)

... and 237 files with indirect coverage changes

@rajkumar-rangaraj rajkumar-rangaraj changed the title [otlp] OTLP Exporter Custom serializer Part 1 - Resources [otlp] OTLP Exporter Custom serializer Part 2 - Resources Oct 23, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 5efc683 into open-telemetry:main Oct 25, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants