Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Update TraceSerializer to use attributes / dropped from state. #5946

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes # Follow up #5941 (comment)

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner October 31, 2024 23:33
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (6250307) to head (2094b97).
Report is 371 commits behind head on main.

Files with missing lines Patch % Lines
...entation/Serializer/ProtobufOtlpTraceSerializer.cs 90.32% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5946      +/-   ##
==========================================
+ Coverage   83.38%   86.52%   +3.13%     
==========================================
  Files         297      262      -35     
  Lines       12531    11803     -728     
==========================================
- Hits        10449    10212     -237     
+ Misses       2082     1591     -491     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.50% <90.32%> (?)
unittests-Project-Stable 86.28% <90.32%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...entation/Serializer/ProtobufOtlpTraceSerializer.cs 89.47% <90.32%> (ø)

... and 243 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit ed1b27f into open-telemetry:main Nov 1, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants