Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Custom serialzer resource tweaks #5947

Conversation

CodeBlanch
Copy link
Member

Changes

  • Updates ProtobufOtlpResourceSerializer so that it doesn't return OtlpTagWriterState from helper methods. This isn't needed because OtlpTagWriterState is passed in by ref

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team as a code owner November 1, 2024 05:15
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.58%. Comparing base (6250307) to head (e036f52).
Report is 374 commits behind head on main.

Files with missing lines Patch % Lines
...ation/Serializer/ProtobufOtlpResourceSerializer.cs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5947      +/-   ##
==========================================
+ Coverage   83.38%   86.58%   +3.20%     
==========================================
  Files         297      262      -35     
  Lines       12531    11804     -727     
==========================================
- Hits        10449    10221     -228     
+ Misses       2082     1583     -499     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.56% <66.66%> (?)
unittests-Project-Stable 86.25% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/Serializer/ProtobufOtlpResourceSerializer.cs 88.23% <66.66%> (ø)

... and 243 files with indirect coverage changes

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for covering this. I had planned to address it after reviewing your last PR.

@CodeBlanch CodeBlanch merged commit 53b85ce into open-telemetry:main Nov 4, 2024
35 checks passed
@CodeBlanch CodeBlanch deleted the otlp-customserializer-resource-tweaks branch November 4, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants