-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Add Trace Exporter to transmit custom serialized data. #5969
Merged
CodeBlanch
merged 9 commits into
open-telemetry:main
from
rajkumar-rangaraj:rajrang/otlpAddHttpTraExp
Nov 14, 2024
Merged
[otlp] Add Trace Exporter to transmit custom serialized data. #5969
CodeBlanch
merged 9 commits into
open-telemetry:main
from
rajkumar-rangaraj:rajrang/otlpAddHttpTraExp
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
label
Nov 12, 2024
rajkumar-rangaraj
changed the title
Add Trace Exporter to transmit custom serialized data.
[otlp] Add Trace Exporter to transmit custom serialized data.
Nov 12, 2024
CodeBlanch
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rajkumar-rangaraj Before you remove all the existing stuff make sure to capture some benchmarks so we can show the new version is better (faster, less/non-allocating) 😄 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Part of #5730,
Design discussion issue #
Changes
Please provide a brief description of the changes here.
This PR introduces the
ProtobufOtlpTraceExporter
, which will replace the currentOtlpTraceExporter
in follow-up PRs. I validated that these changes work as expected by adding the environment variableOTEL_DOTNET_EXPERIMENTAL_USE_CUSTOM_PROTOBUF_SERIALIZER
to the following example applications, enabling them to send data to Aspire Dashboard:The changes were validated, and everything functions as expected. Please note, I marked
ProtobufOtlpTraceExporter
as internal.IProtobufExportClient
will replaceIExportClient
.Test Changes:
No changes to the tests have been made in this PR. This decision was made to avoid redundant work, as the renaming of
ProtobufOtlpTraceExporter
toOtlpTraceExporter
will happen shortly (within a week of this PR being merged). All tests are expected to work with the new implementation, and I’ve verified this locally by manually adjusting the tests, which confirms that everything functions as expected.Next Steps:
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes