Catch exceptions in flush timer and write to EventSource #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illia-M
requested review from
bruno-garcia,
cijothomas,
discostu105,
lmolkova,
MikeGoldsmith,
pjanotti and
SergeyKanzhelev
as code owners
cijothomas
approved these changes
May 23, 2020
|
@Illia-M You'll need to sign the CLA as this is your first time! |
In progress, but it can take a while... |
|
LGTM |
MikeGoldsmith
suggested changes
May 24, 2020
There was a problem hiding this comment.
Thanks @Illia-M. Looks good, just one suggestion to move the try/catch inside FlushAsyncInternal.
MikeGoldsmith
approved these changes
May 24, 2020
|
Thanks @Illia-M - LGTM. |
|
Looks like you'll need to update your PR with recent master branch changes before we can merge. |
Updated |
MikeGoldsmith
added a commit
that referenced
this pull request
May 27, 2020
…ry/opentelemetry-dotnet into batching-activity-processor * 'batching-activity-processor' of github.com:open-telemetry/opentelemetry-dotnet: Catch exceptions in flush timer and write to EventSource (#696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695 .
Changes
In JaegerUdpBatcher on flush timer tick exceptions in async void method cause application crash due to unhandled exception.
Add JaegerExporterEventSource and log handled exceptions on flush try from timer tick.
Checklist
For significant contributions please make sure you have completed the following items:
The PR will automatically request reviews from code owners and trigger CI build and tests.