docker: use Go version as defined in the package #187
Conversation
Debian does provide a different Go version than set in go.mod. Install Go from upstream instead of Debian packages. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
| @@ -8,11 +8,20 @@ RUN cross_debian_arch=$(uname -m | sed -e 's/aarch64/amd64/' -e 's/x86_64/arm64 | |||
| cross_pkg_arch=$(uname -m | sed -e 's/aarch64/x86-64/' -e 's/x86_64/aarch64/'); \ | |||
| apt-get update -y && \ | |||
| apt-get dist-upgrade -y && \ | |||
| apt-get install -y wget make git clang-16 golang unzip \ | |||
| apt-get install -y wget make git clang-16 unzip libc6-dev g++ gcc pkgconf \ | |||
There was a problem hiding this comment.
libc6-dev, g++, gcc+ and pkgconf where installed previously by the package golang and are required dependencies for cgo - see https://packages.debian.org/trixie/golang-1.23-go
There was a problem hiding this comment.
Still better do it explicitly to be independent of golang dependencies, which may change in the future. Explicitly naming the packages also serves as a documentation/reference. Also, it doesn't cost extra time when these packages are already installed.
There was a problem hiding this comment.
Oh nevermind, misread your comment.
|
|
||
| RUN echo "export PATH=\"\$PATH:\$(go env GOPATH)/bin\"" >> ~/.bashrc | ||
| # Append to /etc/profile for login shells | ||
| RUN echo 'export PATH="/usr/local/go/bin:$PATH"' >> /etc/profile |
There was a problem hiding this comment.
In the debian docker in via the file /etc/profile the environment variable is overwritten with this approach:
if [ "$(id -u)" -eq 0 ]; then
PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
else
PATH="/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"
fi
export PATH
Appending export PATH ... here makes sure, that the Go executable is available for every user of this docker image.
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Debian does provide a different Go version than set in go.mod. Install Go from upstream instead of Debian packages.