ebpf: increase number of stack delta buckets #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianl
force-pushed
the
flo-increase-stack-deltas
branch
from
217e554 to
c3bc07b
Compare
With #230 an issue is reported, where the number of stack delta buckets is not sufficient. Increase stack delta bucket to be able to unwind also such executables. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
force-pushed
the
flo-increase-stack-deltas
branch
from
c3bc07b to
d823d2f
Compare
rockdaboot
reviewed
Nov 8, 2024
|
Missing this (I think) in -- &C.exe_id_to_20_stack_deltas, &C.exe_id_to_21_stack_deltas:
++ &C.exe_id_to_20_stack_deltas, &C.exe_id_to_21_stack_deltas, &C.exe_id_to_22_stack_deltas,
++ &C.exe_id_to_23_stack_deltas: |
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Good catch 👍 updated the proposed change. |
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
approved these changes
Nov 11, 2024
felixge
approved these changes
Nov 11, 2024
athre0z
approved these changes
Nov 11, 2024
rockdaboot
force-pushed
the
flo-increase-stack-deltas
branch
from
d67dd54 to
4479caa
Compare
|
Sorry @florianl, I accidentally pushed with |
ltrk2
added a commit
to instana/opentelemetry-ebpf-profiler
that referenced
this pull request
Dec 4, 2024
* Fix unwinding at syscall on aarch64 (open-telemetry#218) * Add PID as an attribute in each sample (open-telemetry#212) * ebpf: increase number of stack delta buckets (open-telemetry#231) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * reporter: use htlhash attribute for profiling specific hash (open-telemetry#236) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * reporter: drop fifo (open-telemetry#239) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * Drop more unused code (open-telemetry#240) * reporter: do not add empty attributes (open-telemetry#233) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * controller: fix reporter interval mix up with monitor interval (open-telemetry#242) * Extract reporter runloop (open-telemetry#228) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co> * Extract lookupcgroupv2 out of the otlp reporter (open-telemetry#227) * Add CPU id to trace and trace metadata (open-telemetry#249) * reporter: don't expire actively used executables (open-telemetry#247) * Remove legacy code from libpf.UnixTime64 (open-telemetry#252) * Turn kernel module file parsing errors into warnings (open-telemetry#255) Co-authored-by: Florian Lehner <florianl@users.noreply.github.com> * readatbuf: add missing check when reading from tail chunk (open-telemetry#259) * metrics: Don't send counters with 0 values (open-telemetry#246) --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: umanwizard <brennan@umanwizard.com> Co-authored-by: Bhavna Jindal <bhavna.jindal@yahoo.com> Co-authored-by: Florian Lehner <florianl@users.noreply.github.com> Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co> Co-authored-by: Nayef Ghattas <nayef.ghattas@datadoghq.com> Co-authored-by: Damien Mathieu <42@dmathieu.com> Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co> Co-authored-by: Tommy Reilly <gnurizen@gmail.com> Co-authored-by: Joel Höner <joel@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #230 an issue is reported, where the number of stack delta buckets is not sufficient.
Increase stack delta bucket to be able to unwind also such executables.
Fixes #230.