-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dice game example #173
Dice game example #173
Conversation
6f6a29b
to
85f7fd5
Compare
I assume it is an accident that this has 919 files? :) |
It's because Phoenix now vendors all the icons from https://heroicons.com/ for newly generated projects. I assume they could be trimmed back since probably only a handful of icons (maybe?) are used in this project 🙂 |
None should be used in this project, so they can all be removed. |
hey @benregn 👋 Thanks for all the work you put in. I want to suggest rewriting the example in Mix plus Cowboy. |
@lessless I'm not the author of this PR but thanks for the suggestion. However in my opinion, an example using Phoenix is probably more helpful because it's used more in the wild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge once the unnecessary files, like icons are removed.
@marcdel ping |
7469193
to
4c19577
Compare
@tsloughter sorry, I totally spaced on this. I regenerated the app without all the html stuff which simplifies it significantly. Happy to add metrics examples as well, but probably as a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just had one change to match the other implementations of the example in other languages.
Thanks! Sounds good with having another PR. |
da516b7
to
b6fc1c3
Compare
@tsloughter boop! rebased this guy, so should be good to go. |
Adds a dice game example in service of this documentation pull request: open-telemetry/opentelemetry.io#2685