Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated warnings_as_errors compile opt for OpentelemetryPhoenix #447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danschultzer
Copy link
Contributor

The CI already runs mix compile --warnings-as-errors so it's not necessary to set this option. It'll remove this warning when running the test:

warning: :warnings_as_errors is deprecated as part of Code.put_compiler_option/2, instead you must pass it as a --warnings-as-errors flag. If you need to set it as a default in a mix task, you can also set it under aliases: [compile: "compile --warnings-as-errors"]
  (elixir 1.18.1) lib/code.ex:1710: Code.put_compiler_option/2
  test/test_helper.exs:2: (file)
  (elixir 1.18.1) src/elixir_compiler.erl:77: :elixir_compiler.dispatch/4
  (elixir 1.18.1) src/elixir_compiler.erl:52: :elixir_compiler.compile/4
  (elixir 1.18.1) src/elixir_compiler.erl:39: :elixir_compiler.maybe_fast_compile/2
  (elixir 1.18.1) src/elixir_lexical.erl:13: :elixir_lexical.run/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant