fixup! fixup! Add record_exception to Erlang

open-telemetry · Nov 29, 2020 · 8bddf4a · 8bddf4a
1 parent 3b03145
commit 8bddf4a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/apps/opentelemetry_api/src/otel_span.erl b/apps/opentelemetry_api/src/otel_span.erl
@@ -114,8 +114,8 @@ add_events(_, _) ->
       Stacktrace :: list(any()),
       Attributes :: opentelemetry:attributes().
 record_exception(SpanCtx, Class, Term, Stacktrace, Attributes) ->
-    ExceptionAttributes = [{<<"exception.type">>, list_to_binary(io_lib:format("~p:~p", [Class, Term]))},
-                           {<<"exception.stacktrace">>, list_to_binary(io_lib:format("~p", [Stacktrace]))}],
+    ExceptionAttributes = [{<<"exception.type">>, iolist_to_binary(io_lib:format("~p:~p", [Class, Term]))},
+                           {<<"exception.stacktrace">>, iolist_to_binary(io_lib:format("~p", [Stacktrace]))}],
     add_event(SpanCtx, <<"exception">>, ExceptionAttributes ++ Attributes).
 
 -spec record_exception(SpanCtx, Class, Term,  Message, Stacktrace, Attributes) -> boolean() when
@@ -126,8 +126,8 @@ record_exception(SpanCtx, Class, Term, Stacktrace, Attributes) ->
       Stacktrace :: list(any()),
       Attributes :: opentelemetry:attributes().
 record_exception(SpanCtx, Class, Term, Message, Stacktrace, Attributes) ->
-    ExceptionAttributes = [{<<"exception.type">>, list_to_binary(io_lib:format("~p:~p", [Class, Term]))},
-                           {<<"exception.stacktrace">>, list_to_binary(io_lib:format("~p", [Stacktrace]))},
+    ExceptionAttributes = [{<<"exception.type">>, iolist_to_binary(io_lib:format("~p:~p", [Class, Term]))},
+                           {<<"exception.stacktrace">>, iolist_to_binary(io_lib:format("~p", [Stacktrace]))},
                            {<<"exception.message">>, Message}],
     add_event(SpanCtx, <<"exception">>, ExceptionAttributes ++ Attributes).