-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tracer configuration merging #221
fix tracer configuration merging #221
Conversation
Approved the changeset on intent. All tests failing is necessary to fix first. That being said, the idea of setting OTLP and getting crash logs explaining what is missing in the config would likely be best for someone wanting it to work in most cases, assuming their intent is ultimately to have that exporter going. For the purposes of docs, would having a "demo" stdout exporter make sense to configure rather than defaulting to nothing? |
Ugh, its the libwxgtk actions change I saw someone mention on twitter. |
https://twitter.com/my_olive_tree/status/1369526310448607234 @puzza007 do you know the fix? |
Woops, pinged Erlanger Paul Oliver instead of Erlanger @paulo-ferraz-oliveira :) |
Aggh, erlef/setup-elixir is also broken but because of libcrypto. |
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 34.96% 34.84% -0.13%
==========================================
Files 37 37
Lines 3037 3045 +8
==========================================
- Hits 1062 1061 -1
- Misses 1975 1984 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7d6a129
to
19c398c
Compare
So I've updated it to have some useful warning logs if the exporter fails to initialize. I'm still unsure if we should default to OTLP exporter or something like stdout. Defaulting to the OTLP exporter, which has default host and port does make for simpler configuration in demos/guides when exporting to a local collector, but maybe that is actually worse since most people in prod will not have the collector on localhost. |
08d559b
to
dd2620c
Compare
Yeah, for the libwx stuff I just "downgraded" to ubuntu-18.04. I'm not sure if it's solved in |
|
Ran into this while working on some examples for docs.
This patch also makes the default exporter be undefined. I'm not sure what the best is here, when its defaulting to OTLP it crashes bad (confusing). So maybe it should instead be stdout or OTLP but handle the crash better to log a message to let the user it tried using OTLP but something wasn't configured or available.