Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug preventing configuring span processors #232

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

garthk
Copy link
Contributor

@garthk garthk commented Mar 24, 2021

If I specify a configuration key under processors other than otel_batch_processor, it crashes with a function clause error. I trust that's unintentional. :)

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #232 (8847e1a) into main (7a7eb9b) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   34.87%   34.73%   -0.15%     
==========================================
  Files          37       37              
  Lines        3051     3052       +1     
==========================================
- Hits         1064     1060       -4     
- Misses       1987     1992       +5     
Flag Coverage Δ
api 61.11% <ø> (ø)
elixir 18.05% <ø> (ø)
erlang 34.58% <0.00%> (-0.15%) ⬇️
exporter 19.48% <ø> (-0.10%) ⬇️
sdk 77.14% <0.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry/src/otel_configuration.erl 78.57% <0.00%> (-1.14%) ⬇️
apps/opentelemetry/src/otel_batch_processor.erl 66.32% <0.00%> (-2.05%) ⬇️
...ntelemetry_exporter/src/opentelemetry_exporter.erl 75.37% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7eb9b...8847e1a. Read the comment docs.

@tsloughter
Copy link
Member

Yup. Thanks!

@tsloughter tsloughter merged commit 4889eda into open-telemetry:main Mar 24, 2021
@garthk garthk deleted the fix/processor-config-crash branch March 24, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants