Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sampler option to start_span and with_span #296

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

tsloughter
Copy link
Member

This was removed from the spec a loooooooooooooong time ago. Luckily we didn't add all those sampler options to libraries so hopefully this isn't an issue for many users? I have an OTEP almost ready for handling the use case of a specific sampler for a tracer.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #296 (0031138) into main (ead6ae1) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   37.35%   37.27%   -0.08%     
==========================================
  Files          46       46              
  Lines        3266     3262       -4     
==========================================
- Hits         1220     1216       -4     
  Misses       2046     2046              
Flag Coverage Δ
api 65.14% <ø> (ø)
elixir 14.41% <ø> (ø)
erlang 37.27% <100.00%> (-0.08%) ⬇️
exporter 19.75% <ø> (ø)
sdk 76.58% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry/src/otel_span_utils.erl 88.00% <ø> (-0.47%) ⬇️
...pps/opentelemetry_api/lib/open_telemetry/tracer.ex 37.50% <ø> (ø)
apps/opentelemetry_api/src/otel_span.erl 66.66% <ø> (ø)
apps/opentelemetry/src/otel_span_ets.erl 64.86% <100.00%> (ø)
apps/opentelemetry/src/otel_tracer_default.erl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead6ae1...0031138. Read the comment docs.

@tsloughter tsloughter force-pushed the rm-sampler-opt branch 2 times, most recently from c30748c to b5f0fcc Compare October 21, 2021 13:10
test/otel_tests.exs Outdated Show resolved Hide resolved
@tsloughter tsloughter merged commit 2170a84 into open-telemetry:main Oct 26, 2021
@tsloughter tsloughter deleted the rm-sampler-opt branch October 26, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants