Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the rest of application env vars to configuration map #328

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

tsloughter
Copy link
Member

Completes the move to having all configuration read and parsed in in _app and passed to sub components. Only other place in the SDK application environment is still read is the app_env resource detector because that is what it is for, so I think it makes sense to leave it as is.

apps/opentelemetry/src/otel_configuration.erl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #328 (c9e0e54) into main (70681ed) will increase coverage by 0.14%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   38.49%   38.63%   +0.14%     
==========================================
  Files          51       51              
  Lines        3510     3499      -11     
==========================================
+ Hits         1351     1352       +1     
+ Misses       2159     2147      -12     
Flag Coverage Δ
api 64.39% <ø> (ø)
elixir 15.12% <ø> (ø)
erlang 38.66% <92.59%> (+0.15%) ⬆️
exporter 21.68% <ø> (ø)
sdk 75.37% <92.59%> (+1.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry/src/otel_configuration.erl 79.09% <90.90%> (+4.31%) ⬆️
apps/opentelemetry/src/otel_resource_detector.erl 93.05% <100.00%> (+9.27%) ⬆️
apps/opentelemetry/src/otel_span_sup.erl 87.50% <100.00%> (ø)
apps/opentelemetry/src/otel_span_sweeper.erl 70.83% <100.00%> (-2.25%) ⬇️
apps/opentelemetry/src/otel_tracer_server.erl 70.00% <100.00%> (-2.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70681ed...c9e0e54. Read the comment docs.

@tsloughter tsloughter merged commit 3d56c11 into open-telemetry:main Dec 16, 2021
@tsloughter tsloughter deleted the app-env-config branch December 16, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants