Exporter boot #338
Merged
Exporter boot #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 29, 2021 12:37
In batch_processor and simple_processor the exporter:init is moved out of the gen_statem `init`. If it fails (returns `undefined`) then the `init` will be attempted again each time spans are to be exported. The only issue is the warnings about failing to init the exporter will continue to print forever if it can never initialize. We can't simply stop trying to init if the failure is one that can never resolve on its own because the exporter can be changed at anytime by the user. This is not meant to be used for retry logic and has no exp backoff. It is only meant to deal with issues like the exporter's deps not being started when the SDK tries to init the exporter and it will soon successfully init because the release is in the process of booting.
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 39.75% 39.79% +0.04%
==========================================
Files 54 54
Lines 3655 3671 +16
==========================================
+ Hits 1453 1461 +8
- Misses 2202 2210 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ferd
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In batch_processor and simple_processor the exporter:init is moved out of the
gen_statem
init. If it fails (returnsundefined) then theinitwill beattempted again each time spans are to be exported.
The only issue is the warnings about failing to init the exporter
will continue to print forever if it can never initialize. We
can't simply stop trying to init if the failure is one that can
never resolve on its own because the exporter can be changed at
anytime by the user.
This is not meant to be used for retry logic and has no exp
backoff. It is only meant to deal with issues like the exporter's
deps not being started when the SDK tries to init the exporter and
it will soon successfully init because the release is in the
process of booting.