Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and add exporter options #341

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

tsloughter
Copy link
Member

Added a couple new environment variables for configuring the exporter, from https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options

Also updates the port for http_protobuf to the default used in the specification.

@tsloughter tsloughter requested a review from a team January 3, 2022 21:40
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #341 (e16ffd3) into main (a22fb0e) will increase coverage by 16.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #341       +/-   ##
===========================================
+ Coverage   16.44%   33.33%   +16.89%     
===========================================
  Files          21       56       +35     
  Lines         596     4563     +3967     
===========================================
+ Hits           98     1521     +1423     
- Misses        498     3042     +2544     
Flag Coverage Δ
api 67.28% <ø> (+50.83%) ⬆️
elixir 16.44% <ø> (ø)
erlang 33.27% <100.00%> (?)
exporter 21.47% <100.00%> (?)
sdk 77.13% <ø> (?)
zipkin 2.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntelemetry_exporter/src/opentelemetry_exporter.erl 74.09% <100.00%> (ø)
apps/opentelemetry/src/otel_resource_env_var.erl 87.50% <0.00%> (ø)
apps/opentelemetry/src/otel_span_sweeper.erl 70.83% <0.00%> (ø)
apps/opentelemetry/src/otel_links.erl 73.33% <0.00%> (ø)
apps/opentelemetry/src/otel_span_utils.erl 90.62% <0.00%> (ø)
.../opentelemetry_zipkin/src/opentelemetry_zipkin.erl 38.98% <0.00%> (ø)
apps/opentelemetry/src/otel_tracer_default.erl 100.00% <0.00%> (ø)
...elemetry/src/otel_sampler_trace_id_ratio_based.erl 71.42% <0.00%> (ø)
apps/opentelemetry/src/otel_exporter_pid.erl 80.00% <0.00%> (ø)
...metry_exporter/src/opentelemetry_trace_service.erl 25.00% <0.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22fb0e...e16ffd3. Read the comment docs.

@tsloughter tsloughter merged commit 1b90aa7 into open-telemetry:main Jan 3, 2022
@tsloughter tsloughter deleted the protocol-compression-env branch January 3, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants