Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v0.7.0 release of contrib #103

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Prepare for v0.7.0 release of contrib #103

merged 4 commits into from
Jun 29, 2020

Conversation

evantorrie
Copy link
Contributor

This upgrades the dependency on go.opentelemetry.io/otel to the just-released v0.7.0 and fixes API changes causing breakage in the metric exporters.

@evantorrie evantorrie force-pushed the pre_release_v0.7.0 branch from a8bfd7e to daa2b9b Compare June 27, 2020 15:47
MrAlias
MrAlias reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to remove the internal/trace functionality that was moved to the main repo's api/standard package? Or, should that be a separate PR?

This was referenced Jun 29, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@MrAlias MrAlias linked an issue Jun 29, 2020 that may be closed by this pull request
Upgrade to v0.7.0 of go.opentelemetry.io/otel #102
Closed
@Aneurysm9
Copy link
Member

Aneurysm9 commented Jun 29, 2020 •
edited
Loading

Did we want to remove the internal/trace functionality that was moved to the main repo's api/standard package? Or, should that be a separate PR?

I up a separate PR, though it's based on this one so it should be reviewed and merged after this one lands.

@Aneurysm9 Aneurysm9 mentioned this pull request Jun 29, 2020
Merged
MrAlias
MrAlias approved these changes Jun 29, 2020
View reviewed changes
exporters/metric/dogstatsd/dogstatsd_test.go Outdated Show resolved Hide resolved
@evantorrie
Copy link
Contributor Author

Did we want to remove the internal/trace functionality that was moved to the main repo's api/standard package? Or, should that be a separate PR?

I up a separate PR, though it's based on this one so it should be reviewed and merged after this one lands.

Yes, I was planning a separate PR. There's also at least one other separate PR for the use of semantic tag names that have now shuffled off into the main Otel repo.

@evantorrie @MrAlias
Update exporters/metric/dogstatsd/dogstatsd_test.go
f4b3298 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit 9890acb into open-telemetry:master Jun 29, 2020
@evantorrie evantorrie deleted the pre_release_v0.7.0 branch June 30, 2020 00:00
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@krnowak @rghetia
Fix parent span ID formatting (#103)
fafb3da 
It was printing an ID of the created span instead. Also drop the if
clause checking if span has a parent span ID - we know at this point
that the condition is always true.
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Upgrade to v0.7.0 of go.opentelemetry.io/otel
4 participants
@evantorrie @Aneurysm9 @MrAlias @pellared