Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS detector #139

Merged
merged 7 commits into from
Jul 27, 2020
Merged

AWS detector #139

merged 7 commits into from
Jul 27, 2020

Conversation

YANYZP
Copy link
Contributor

@YANYZP YANYZP commented Jul 20, 2020

The prototype is done. Please feel free to comment it.

@YANYZP
Copy link
Contributor Author

YANYZP commented Jul 22, 2020

AWS detector is independent of GCP detector and is ready for review.

MrAlias
MrAlias approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a line to the Changelog about the addition here as well?

Thanks for the contribution 😄

@lizthegrey
Copy link
Member

Same comment on dependabot.yml

@YANYZP
Copy link
Contributor Author

YANYZP commented Jul 24, 2020

Included aws module in dependabot.yml

@YANYZP
Copy link
Contributor Author

YANYZP commented Jul 27, 2020

Ready for final review

@MrAlias MrAlias merged commit f28c81d into open-telemetry:master Jul 27, 2020
@MrAlias MrAlias mentioned this pull request Jul 31, 2020
Merged
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@rghetia
replace -printf option with -exec in find cmd for go.mod directories. (…
b13362e 
…#139)
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@lizthegrey lizthegrey lizthegrey approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.
4 participants
@YANYZP @lizthegrey @MrAlias @pellared