Instrumentation for github.com/bradfitz/gomemcache #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
|
I see now that recently tests requiring external resources were set to be run in CircleCI, perhaps same should be done for integration tests here, as they should be run with a functioning instance of memcached server? |
Aneurysm9
reviewed
Aug 11, 2020
instrumentation/github.com/bradfitz/gomemcache/example/client.go
Outdated
Show resolved
Hide resolved
Yep! Just follow the same approach as the mongo or gocql packages |
jmacd
reviewed
Aug 11, 2020
instrumentation/github.com/bradfitz/gomemcache/example/client.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/bradfitz/gomemcache/example/client.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/bradfitz/gomemcache/example/client.go
Outdated
Show resolved
Hide resolved
added 2 commits
August 12, 2020 13:17
- accept trace provider in config - adjust example to reflect this change - adjust example to use single copy of client with context - define KV key constant for item key key - adjust tests
Aneurysm9
approved these changes
Aug 13, 2020
MrAlias
approved these changes
Aug 13, 2020
instrumentation/github.com/bradfitz/gomemcache/example/README.md
Outdated
Show resolved
Hide resolved
- use operation type for operation names - include multiple keys in span attribute, if applicable - typos, naming convention fixes
MrAlias
approved these changes
Aug 14, 2020
Merged
6 tasks
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #90
Description
Introduces tracing instrumentation for the memcache client gomemcache. Similarly to the proir art (https://github.com/DataDog/dd-trace-go/tree/v1/contrib/bradfitz/gomemcache/memcache), the implementation works by wrapping the memcache client and subsequently tracing every operation call.
Tasks