Unify and improve GCP resource detection #2223
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of installing different resource detectors for different GCP platforms, this PR creates a single detector for all platforms. It works by looking for unique environment variables for the platform, and then detecting the rest based on which it finds. The result is a much more consistent detector; it adds the appropriate CloudPlatform attribute for all platforms, and now shares all discovery logic between cloud run and cloud functions. Cloud Functions, Cloud Run, and Google App Engine (new) now all set FaaS resource attributes, instead of service attributes, which more closely aligns with semantic conventions.
This removes support for some kubernetes resource attributes (e.g. k8s.container.name). These don't belong in the GCP resource detection code, and should ideally be set by shared resource detectors (e.g. open-telemetry/oteps#195). For now, users can achieve the same behavior as before with this in their pod spec:
I still need to address some outstanding TODOs here, and manually test this in various environments.