[cortex] Authentication Implementation and Timestamp Fix #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 18, 2020 14:30
ercl
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
connorlindsey
approved these changes
Aug 18, 2020
lizthegrey
changed the title
MrAlias
reviewed
Aug 19, 2020
connorlindsey
approved these changes
Aug 20, 2020
jmacd
approved these changes
Aug 20, 2020
|
@ercl this looks ready to merge. Can you sync with master? |
…ontrib into authentication
|
Merged! |
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
… to avoid module problems) (#246) * automate building all the examples the EXAMPLES variable was out of date - the stackdriver example wasn't even built let's automate it, so we don't need to remember about updating the variable after adding a new example to the examples directory * move jaeger example to example directory this should be in the examples directory, so it can be built by the make test during CI. * switch to go 1.13 circle ci uses go 1.12 (which is the oldest 1.12 release) that contains some bugs with module handling let's switch to go 1.13.3, the latest go currently * use a single valid revision of the project in go.mod files this probably shouldn't be a problem since the switch to go 1.13 in circle ci, but cleans up the mess and the use of bogus releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements BasicAuth and bearer token authentication. Additionally, it fixes an issue of timestamps being in seconds instead of milliseconds.