[propagator] Set sampling bit when sampling decision is debug #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 Propagator. According to the spec. Debug sampling decision implies accept(sampled) decision. But we didn't set sample bitmask. So when trace state is debug, `IsSampled` method will still return false, which is different from spec. Now we make sure when debug bitmask is set, sample bitmask will also be set.
TommyCpp
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
XSAM
approved these changes
Sep 27, 2020
MrAlias
approved these changes
Sep 28, 2020
TommyCpp
changed the title
jmacd
approved these changes
Sep 29, 2020
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Make span start/end configuration more greppable Rename SpanOption to StartOption Rename StartOptions to StartConfig Rename EndOptions to EndConfig fixes #197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #367
According to the spec. Debug sampling decision implies accept(sampled) decision.
But we didn't set sample bitmask. So when trace state is debug,
IsSampledmethod will still return false, which is different from spec.Now we make sure when debug bitmask is set, sample bitmask will also be set.