Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: Add SpanStartOptions #3768

Merged
merged 9 commits into from
Aug 11, 2023
Merged

otelgrpc: Add SpanStartOptions #3768

merged 9 commits into from
Aug 11, 2023

Conversation

dubonzi
Copy link
Contributor

@dubonzi dubonzi commented May 2, 2023

Closes #3683.

@dubonzi dubonzi requested a review from a team May 2, 2023 19:36
@codecov
Copy link

codecov bot commented May 2, 2023 •
edited
Loading

Codecov Report

Merging #3768 (03f16e6) into main (e439286) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3768   +/-   ##
=====================================
  Coverage   79.3%   79.4%           
=====================================
  Files        166     166           
  Lines      10336   10360   +24     
=====================================
+ Hits        8206    8230   +24     
  Misses      1996    1996           
  Partials     134     134
Files Changed Coverage Δ
...entation/google.golang.org/grpc/otelgrpc/config.go 73.2% <100.0%> (+2.0%) ⬆️
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 85.7% <100.0%> (+0.7%) ⬆️

@dubonzi dubonzi force-pushed the otelgrpc-span-options branch from 7a9fdf2 to f26698c Compare July 25, 2023 15:16
@dubonzi dubonzi requested a review from ash2k July 25, 2023 16:08
@dubonzi dubonzi requested a review from ash2k July 26, 2023 14:59
ash2k
ash2k approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ash2k ash2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a maintainer here.

@pellared
Copy link
Member

@dubonzi Can you please update the branch (resolve conflicts)?

@dashpole @hanyuancheung Can you please review (as codeowners)?

@dubonzi dubonzi force-pushed the otelgrpc-span-options branch from 3eed923 to 03f16e6 Compare August 10, 2023 09:25
@dubonzi
Copy link
Contributor Author

dubonzi commented Aug 10, 2023 •
edited by pellared
Loading

@dubonzi Can you please update the branch (resolve conflicts)?

All done

@pellared pellared changed the title [otelgrpc] add option to set SpanStartOptions otelgrpc: Add SpanStartOptions Aug 11, 2023
@pellared pellared merged commit 2ccb63e into open-telemetry:main Aug 11, 2023
@MrAlias MrAlias added this to the v0.43.0 milestone Aug 28, 2023
@MrAlias MrAlias mentioned this pull request Aug 28, 2023
Merged
@josepedropereira josepedropereira mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@pellared pellared pellared approved these changes

@ash2k ash2k ash2k approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MrAlias MrAlias Awaiting requested review from MrAlias

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dmathieu dmathieu Awaiting requested review from dmathieu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.43.0
Development

Successfully merging this pull request may close these issues.

otelgrpc: add WithSpanOptions
5 participants
@dubonzi @pellared @ash2k @hanyuancheung @MrAlias