Add convenience wrappers for http.Get/Post, etc. #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add convenience wrappers for http.{Get,Post,Head,PostForm}
using the otelhttp transport and taking a context.Context directly.
Makes instrumenting code using the original http convenience methods a
one-line change instead of a multiline one.
johnbley
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Aneurysm9
reviewed
Oct 9, 2020
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Added to CHANGELOG. Tests might need to wait a bit. |
XSAM
reviewed
Oct 10, 2020
XSAM
reviewed
Oct 13, 2020
Co-authored-by: Sam Xie <xsambundy@gmail.com>
XSAM
approved these changes
Oct 13, 2020
MrAlias
reviewed
Oct 14, 2020
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Oct 14, 2020
Aneurysm9
suggested changes
Oct 14, 2020
Aneurysm9
approved these changes
Oct 20, 2020
|
@johnbley one last thing, it looks like the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add convenience wrappers for http.{Get,Post,Head,PostForm}
using the otelhttp transport and taking a context.Context directly.
Makes instrumenting code using the original http convenience methods a
one-line change instead of a multiline one.