[aws detector] Remove error when instance metadata is unavailable #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dackroyd
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
|
> Note the failure to detect any resource information MUST NOT be > considered an error When instance metadata is not available, this should not be treated as an error. Small refactoring required to allow tests to mock the client, which should be _mostly_ non-impacting for consumers.
dackroyd
force-pushed
the
remove-error-when-detecting-aws-resource-when-metadata-unavailable
branch
from
0cdc7bc to
8807fae
Compare
dackroyd
commented
Oct 14, 2020
MrAlias
approved these changes
Oct 14, 2020
Aneurysm9
approved these changes
Oct 15, 2020
dackroyd
deleted the
remove-error-when-detecting-aws-resource-when-metadata-unavailable
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instance metadata is not available, this should not be treated as an error.
Small refactoring required to allow tests to mock the client, which should be mostly non-impacting for consumers.
Fixes #398