change the Filter parameter from *http.Request to *gin.Context #3070

[rehanpfmr]

change #3070

[dmathieu]

Please do not delete instrgen/docs/flow.png.

[dmathieu]

Note that you don't need to close/reopen PRs for every change made. If you push a new commit (or amend an existing commit) to the same branch on your fork, the PR will be updated.

[rehanpfmr]

I had unexplainable issue fixing GO package changes, So i had to just close and reopen new one. I hope I will no longer have to do it again.

[dmathieu]

The instrgen/docs/flow.png file is currently deleted in your PR. Could you bring it back?

[rehanpfmr]

@dmathieu the instrgen/docs/flow.png is already there. However it shows as "Unable to render rich display Invalid image source"
04e9f5b

[rehanpfmr]

please help fix the image

[dmathieu]

Yes, it's already on the main branch of the repository. But if you look at the diff for your PR (https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4375/files), you will see it changes when it shouldn't.

[codecov]

Codecov Report

Merging #4375 (86bb9a7) into main (f567afc) will not change coverage.
The diff coverage is 100.0%.

❗ Current head 86bb9a7 differs from pull request most recent head c7b00b6. Consider uploading reports for the commit c7b00b6 to get more accurate results

@@          Coverage Diff          @@
##            main   #4375   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        144     144           
  Lines      10002   10002           
=====================================
  Hits        8232    8232           
  Misses      1632    1632           
  Partials     138     138           

Files	Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go	83.5% <100.0%> (ø)
...ntation/github.com/gin-gonic/gin/otelgin/option.go	100.0% <ø> (ø)

[rehanpfmr]

Can this be merged?

[pellared]

in branch of the repository. But if you look at the diff for your PR (https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4375/files), you will see it chan

This issue is not addressed.

This branch is out-of-date with the base branch

You need to make sure to keep the branch up to date.

[rehanpfmr]

@dmathieu
Would you please review and approve this https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4444/files

[pellared]

Superseded by #4444