Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Security Workflows to GitHub Actions (1/2): codeql workflow #506

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

AzfaarQureshi
Copy link
Contributor

Motivation

Follow up to issue Follow up to issue open-telemetry/oteps#144

CodeQL is GitHub's static analysis engine which scans repos for security vulnerabilities. As the project grows and we near GA it might be useful to have a workflow which checks for security vulnerabilities with every PR so we can ensure every incremental change is following best development practices. Also passing basic security checks will also make sure that there aren't any glaring issues for our users.

Changes

  • This PR adds CodeQL security checks to the repo
  • After every run the workflow uploads the results to GitHub. Details on the run and security alerts will show up in the security tab of this repo.

Workflow Triggers

  • daily cron job at 1:30am
  • workflow_dispatch (in case maintainers want to trigger a security check manually)

cc- @alolita

@MrAlias
Copy link
Contributor

MrAlias commented Jan 6, 2021

@AzfaarQureshi please update with base branch. This looks ready to merge.

@AzfaarQureshi
Copy link
Contributor Author

@MrAlias rebased!

(copying over question from the go-core PR)

just a quick question, do you want codeql to run on every PR as well or just once daily via the cron job? I just realized that the description is outdated from back when I had the PR trigger as well but I removed it cause I thought it would be too frequent. What are your thoughts?

@MrAlias MrAlias merged commit f6da9db into open-telemetry:master Jan 6, 2021
@MrAlias
Copy link
Contributor

MrAlias commented Jan 6, 2021

(copying over question from the go-core PR)

just a quick question, do you want codeql to run on every PR as well or just once daily via the cron job? I just realized that the description is outdated from back when I had the PR trigger as well but I removed it cause I thought it would be too frequent. What are your thoughts?

For those following this, I agreed that it was too frequent and the once a night is good.

plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
)

* update provider to use AlwaysSampler instead of ProbabilitySampler

* remove unused defaultSamplingProbability constant

* fix broken tests

* update failure message in test

* fix test description

Co-authored-by: Rahul Patel <rghetia@yahoo.com>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants