Add skeleton of slog bridge #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
the
Skip Changelog
MrAlias
force-pushed
the
sloghandler-skeleton
branch
3 times, most recently
from
09d2d98 to
03ec4ac
Compare
MrAlias
force-pushed
the
sloghandler-skeleton
branch
from
03ec4ac to
0d8443c
Compare
dashpole
reviewed
Mar 18, 2024
dashpole
reviewed
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5292 +/- ##
=======================================
- Coverage 61.2% 61.1% -0.2%
=======================================
Files 185 186 +1
Lines 11207 11228 +21
=======================================
Hits 6865 6865
- Misses 4142 4163 +21
Partials 200 200
|
Add LoggerProvider as an option. Rename New to NewHandler. Add the New function to return an *slog.Logger.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
pellared
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5195