-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Semconv migration Part1 Server - v1.20.0 support #5333
HTTP Semconv migration Part1 Server - v1.20.0 support #5333
Conversation
Removed Metrics Placeholders
Added changelog.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5333 +/- ##
=======================================
+ Coverage 62.1% 62.3% +0.1%
=======================================
Files 186 189 +3
Lines 11537 11575 +38
=======================================
+ Hits 7176 7219 +43
+ Misses 4149 4146 -3
+ Partials 212 210 -2
|
instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
Outdated
Show resolved
Hide resolved
instrumentation/net/http/otelhttp/internal/semconvutil/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
Outdated
Show resolved
Hide resolved
Please address the lint failures. |
instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
Outdated
Show resolved
Hide resolved
instrumentation/net/http/otelhttp/internal/semconv/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
Removed benchmark Updated license header to SPDX format Restored splitHostPort Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the code. I just focused on resolving some of the addressed comments.
instrumentation/net/http/otelhttp/internal/semconv/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
instrumentation/net/http/otelhttp/internal/semconv/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
Side note, please do not wait on my review. |
…#5333) * added interface around semconvutil --------- Signed-off-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
…#5333) * added interface around semconvutil --------- Signed-off-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
// ServerStatus returns a span status code and message for an HTTP status code | ||
// value returned by a server. Status codes in the 400-499 range are not | ||
// returned as errors. | ||
func ServerStatus(code int) (codes.Code, string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MadVikingGod Could you explain why we cannot use codes.Ok
for statuses in the range of 200..399
, or at least for 2xx
?
This change adds an absctraction layer to the semconv of otlehttp. This is to enable compatibility mode that was required in the v1.21.0 semantic convention.
The full PR is #5092
Part of #5331