Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/stretchr/testify from 1.6.1 to 1.7.0 in /instrumentation/google.golang.org/grpc/otelgrpc #544

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2021

Bumps github.com/stretchr/testify from 1.6.1 to 1.7.0.

Release notes

Sourced from github.com/stretchr/testify's releases.

Minor improvements and bug fixes

Minor feature improvements and bug fixes

Commits
  • acba37e Only use repeatability if no repeatability left
  • eb8c41e Add more tests to mock package
  • a5830c5 Extract method to evaluate closest match
  • 1962448 Use Repeatability as tie-breaker for closest match
  • 92707c0 Fixed the link to not point to assert only
  • 05dd0b2 Updated the readme to point to pkg.dev
  • c26b7f3 Update assertions.go
  • 8fb4b24 [Fix] The most recent changes to golang/protobuf breaks the spew Circular dat...
  • dc8af72 add generated code for positive/negative assertion
  • 1544508 add assert positive/negative
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.6.1...v1.7.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels Jan 17, 2021
@MrAlias
Copy link
Contributor

MrAlias commented Jan 20, 2021

Superseded by #557

@MrAlias MrAlias closed this Jan 20, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 20, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@MrAlias MrAlias deleted the dependabot/go_modules/instrumentation/google.golang.org/grpc/otelgrpc/github.com/stretchr/testify-1.7.0 branch January 20, 2021 16:54
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* Initial metrics addition to the OTLP exporter

* Fixes

Update to incorporate merged changes.
Fix lint issues.

* Add sum float64 transform unit test

* Fix static check

* Update comments

Fix malformed License header.
Add documentation for new transform functions.
Remove errant TODO.

* Fix test failures and handle ErrEmptyDataSet

Use `assert.NoError` instead of `assert.Nil` to correctly display
checked errors.

Use the result of `assert.NoError` to guard against `nil` pointer
dereferences.

Add check to skip `Record`s that return an `ErrEmptyDataSet` error and
include test to check this error is correctly returned from the
transform package.

Co-authored-by: Rahul Patel <rahulpa@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants