Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the AWS propagators #5647

Merged
merged 3 commits into from
May 23, 2024
Merged

Deprecate the AWS propagators #5647

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ce7545
Deprecate the AWS propagators
MrAlias May 22, 2024
008199e
Merge branch 'main' into dep-prop-aws
MrAlias May 23, 2024
f7d6a66
Merge branch 'main' into dep-prop-aws
MrAlias May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- The `go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5551]. (#5598)
- The `go.opentelemetry.io/contrib/propagators/aws` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5553]. (#5647)

[#5551]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5551
[#5553]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5553

## [1.27.0/0.52.0/0.21.0/0.7.0/0.2.0] - 2024-05-21

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-lambda-go/otellambda/test/lambda_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (

lambdadetector "go.opentelemetry.io/contrib/detectors/aws/lambda"
"go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda"
"go.opentelemetry.io/contrib/propagators/aws/xray"
"go.opentelemetry.io/contrib/propagators/aws/xray" // nolint:staticcheck // deprecated.
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/sdk/instrumentation"
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig/xrayconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

lambdadetector "go.opentelemetry.io/contrib/detectors/aws/lambda"
"go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda"
"go.opentelemetry.io/contrib/propagators/aws/xray"
"go.opentelemetry.io/contrib/propagators/aws/xray" // nolint:staticcheck // deprecated.
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
"go.opentelemetry.io/otel/propagation"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig/xrayconfig_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/stretchr/testify/assert"

"go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda"
"go.opentelemetry.io/contrib/propagators/aws/xray"
"go.opentelemetry.io/contrib/propagators/aws/xray" // nolint:staticcheck // deprecated.
"go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/trace"
v1common "go.opentelemetry.io/proto/otlp/common/v1"
Expand Down
2 changes: 1 addition & 1 deletion propagators/autoprop/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"strings"
"sync"

"go.opentelemetry.io/contrib/propagators/aws/xray"
"go.opentelemetry.io/contrib/propagators/aws/xray" // nolint:staticcheck // deprecated.
"go.opentelemetry.io/contrib/propagators/b3"
"go.opentelemetry.io/contrib/propagators/jaeger"
"go.opentelemetry.io/contrib/propagators/ot"
Expand Down
1 change: 1 addition & 0 deletions propagators/aws/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Deprecated: aws has no Code Owner.
module go.opentelemetry.io/contrib/propagators/aws

go 1.21
Expand Down
2 changes: 2 additions & 0 deletions propagators/aws/xray/README.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# AWS X-Ray Propagator/IDGenerator

:warning: Deprecated: aws has no Code Owner.

This package contains an AWS X-Ray compatible `TextMapPropagator` and `IDGenerator`.

## `traceIdRatioSampler` and `x-ray IDGenerator` compatibility
Expand Down
8 changes: 8 additions & 0 deletions propagators/aws/xray/propagator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// Package xray provide an OpenTelemetry propagator for the AWS XRAY platform.
//
// Deprecated: aws has no Code Owner.
// After August 21, 2024, it may no longer be supported and may stop
// receiving new releases unless a new Code Owner is found. See
// [this issue] if you would like to become the Code Owner of this module.
//
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5553
package xray // import "go.opentelemetry.io/contrib/propagators/aws/xray"

import (
Expand Down